-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix including interval in response of device authorization request #1410
Open
hafezdivandari
wants to merge
13
commits into
thephpleague:master
Choose a base branch
from
hafezdivandari:master-fix-some-bugs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix including interval in response of device authorization request #1410
hafezdivandari
wants to merge
13
commits into
thephpleague:master
from
hafezdivandari:master-fix-some-bugs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2024
@hafezdivandari apologies I've not forgotten about this. My partner is sick just now and my son has a sickness bug so I have little time but will get to it as soon as she is better. Apologies for the delay. Just wanted to give you an update |
@Sephster No worries at all! Take all the time you need. I hope your family feels better soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
DeviceCodeRepositoryInterface::getDeviceCodeEntityByDeviceCode()
argument,string $deviceCodeEntity
->string $deviceCode
.$grant->setIntervalVisibility(true)
the response still doesn't includeinterval
. On the response you are excludinginterval
when it's set to default 5. Although the server may use the default interval value, we still want to include theinternal
on the response.slow_down
error happens, because the exception is thrown before callingpersistDeviceCode
.slow_down
error happens according to section 3.5 of RFC8628.slow_down
error response where returned even after the user has completed the auth flow (already approved / denied the request).interval
value onauthorization_pending
andslow_down
error responses.