Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix including interval in response of device authorization request #1410

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented May 22, 2024

This PR does:

  • Fix a typo on DeviceCodeRepositoryInterface::getDeviceCodeEntityByDeviceCode() argument, string $deviceCodeEntity -> string $deviceCode.
  • Fix a bug where enabling the interval visibility is ignored:
    • RFC8628 Section 3.2
    • Even by explicitly calling $grant->setIntervalVisibility(true) the response still doesn't include interval. On the response you are excluding interval when it's set to default 5. Although the server may use the default interval value, we still want to include the internal on the response.
  • Fix a bug where the new poll date is not persisted when slow_down error happens, because the exception is thrown before calling persistDeviceCode.
  • Increase interval by 5 when slow_down error happens according to section 3.5 of RFC8628.
  • Fix a bug where slow_down error response where returned even after the user has completed the auth flow (already approved / denied the request).
  • Include the interval value on authorization_pending and slow_down error responses.

@Sephster
Copy link
Member

Sephster commented Jul 2, 2024

@hafezdivandari apologies I've not forgotten about this. My partner is sick just now and my son has a sickness bug so I have little time but will get to it as soon as she is better. Apologies for the delay. Just wanted to give you an update

@hafezdivandari
Copy link
Contributor Author

@Sephster No worries at all! Take all the time you need. I hope your family feels better soon.

@hafezdivandari
Copy link
Contributor Author

Hi @Sephster, hope you’re doing well. Any progress on the PRs related to Laravel Passport? I’ve listed them all here.

@hafezdivandari hafezdivandari mentioned this pull request Oct 10, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants