Fix authorization request is not redirecting when code_challenge is invalid
#1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hafezdivandari
changed the title
code_challenge error is not redirectingcode_challenge is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1039
On authorization request of "Authorization Code" flow, after client is verified and redirect URI is finalized, the client expects the error response to be redirected back to the URI with "state" parameter set if provided.
This PR fixes a bug where
code_challengeorcode_challenge_methodparameters are invalid and the server responses with error 400 instead of redirecting to URI witherrorandstateparameters.