Return exit code from CLI::run(), rather than exiting #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea. Why ever I hadn't done that in the first place... Thanks! |
|
No worries, and welcome! :-) However, I just missed two return points! Was just a second to late! |
|
Just add a new PR for those. |
|
Ok, so I'm not creating a new one. Would you also mind to ad the return type |
|
Return type hints of Yes, this project is that old, and I'd have to cleanup a lot to justify the upgrade. Something I'd certainly like to do, but i won't have time for in any somewhat near future. |
|
I see. Thanks for the heads-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
CLIfrom another script, exiting straight fromrun()method does not allow custom error handling.Returning the exit code to the invoking script and exiting there allows custom error handling in an external script, while remaining completely backwards-compatible.