Skip to content

Commit

Permalink
Fix quite escape in env output build step
Browse files Browse the repository at this point in the history
The parameter determination task outputs the GitHub event JSON via a bash echo, but it was being done in single quotes. This meant PR descriptions with apostrophes or single quotes could break the escaping. Output is now in a heredoc block.
  • Loading branch information
Shadowfiend authored Jun 19, 2023
1 parent 338aeb0 commit 16b6e6d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ jobs:
- name: Output environment
run: |
echo '${{ github.ref }}'
echo '${{ toJSON(github.event) }}'
echo <<-EOF
${{ toJSON(github.event) }}
EOF
outputs:
# Run builds for all non-comment triggers.
should-build: >-
Expand Down

0 comments on commit 16b6e6d

Please sign in to comment.