Adjust auto-tagging #305
Merged
Adjust auto-tagging #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This PR removes the custom channel auto-tagging for `#hiring` channel while also some refactoring in order to account for empty arrays better, since before it relied on at least one entry there at all times.
Shadowfiend
reviewed
Apr 17, 2024
Co-authored-by: Antonio Salazar Cardozo <[email protected]>
This commits fixes up the `auto-join.ts` in favor of mapping, along with refactoring everything to make it smoother.
|
@Shadowfiend Just pushed a update with this feedback! Now it's much cleaner and switched interface in favor of |
Shadowfiend
approved these changes
Apr 19, 2024
| @@ -23,7 +23,11 @@ import { | |||
| // it to mention the right role. Discord's behavior in this scenario is not to | |||
| // ping the role, but to add all its members to the thread. | |||
|
|
|||
| const CUSTOM_CHANNEL_ROLE = [{ channelName: "hiring", roleName: "PeopleOps" }] | |||
| const CUSTOM_CHANNEL_ROLE: Record<string, string> = { | |||
There was a problem hiding this comment.
Fwiw the one downside of Record<string, string> is that it removes our ability to name either string. Whereas we could do:
const CUSTOM_ROLE_TAG_BY_CHANNEL: { [channelName: string]: string } = {
...
}Mostly academic, but useful to know :) channelName here does nothing other than provide a hint to the programmer as to what the key of the object is meant to be.
| if (channelMatchingRole) { | ||
| await placeholder.edit(channelMatchingRole.toString()) | ||
| return | ||
| if (hasCustomChannels && containingChannel) { |
There was a problem hiding this comment.
The way this control flows, we don't even need hasCustomChannels—if there are no custom channels, roleName will never pass if (roleName), and we'll continue to the following components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR removes the custom channel auto-tagging for
#hiringchannel while also some refactoring in order to account for empty arrays better, since before it relied on at least one entry there at all times.