Fix nickname change #320
Merged
Fix nickname change #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes Change `member.user.username` to `member.displayName` to resolve username replacing the nickname in the event the initial member.nickname isn't grabbed. Remove excess logging on each server nicknames.
Shadowfiend
reviewed
Nov 14, 2024
| @@ -84,7 +80,7 @@ export default async function webhookDiscord( | |||
| if (!userId) throw new Error("User not found with the specified name") | |||
|
|
|||
| const member = await guild.members.fetch(userId) | |||
| const currentNickname = member.nickname || member.user.username | |||
| const currentNickname = member.nickname ?? member.displayName | |||
There was a problem hiding this comment.
Should this then fall back one more time on the username, or does display name handle that? What's the difference between display name and nickname? It feels like that might be backwards (display name being server specific and nick being global maybe?).
There was a problem hiding this comment.
The nice part about member.displayName (doc link) is it will load Guild nickname again and then if a nickname isn't set, default to username.
There was a problem hiding this comment.
Should we only use that in that case?
Shadowfiend
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Change
member.user.usernametomember.displayNameto resolve username replacing the nickname in the event the initial member.nickname isn't grabbed.Remove excess logging on each server nicknames.