Replaced deprecated string conversion function #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
set(CMAKE_CXX_STANDARD 11) in CMakeLists.txt is not c++17. |
|
@sonoro1234 I'm aware that the main repo currently uses C++11, but I have an ongoing personal project using C++17, and I am compiling RtAudio statically for that project. It's not a huge deal since as you said, C++11 is not deprecated, I just figured it is better to future-proof as long as the solution still works in C++11. Feel free to drop the pull request if you disagree, it still works as intended in my project. |
|
You did not said it works with c++11!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building RtAudio on Mac with C++17, a deprecation warning is thrown for the
std::wstring_convertclass. This pull request replaces that usage with conversion functions that have not been deprecated.