perf: optimize passkey authentication for iOS 15 (#5214)

thirdweb-dev · Oct 29, 2024 · ad4af68 · ad4af68
1 parent 8861982
commit ad4af68
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/.changeset/smart-chicken-beam.md b/.changeset/smart-chicken-beam.md
@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Reduce async calls before requesting webauthn credentials for ios 15
diff --git a/packages/thirdweb/src/wallets/in-app/core/authentication/passkeys.ts b/packages/thirdweb/src/wallets/in-app/core/authentication/passkeys.ts
@@ -137,19 +137,17 @@ export async function loginWithPasskey(options: {
   }
   const fetchWithId = getClientFetch(options.client, options.ecosystem);
   // 1. request challenge from  server/iframe
-  const res = await fetchWithId(getChallengePath("sign-in"));
-  const challengeData = await res.json();
+  const [challengeData, credentialId] = await Promise.all([
+    fetchWithId(getChallengePath("sign-in")).then((r) => r.json()),
+    options.storage?.getPasskeyCredentialId(),
+  ]);
   if (!challengeData.challenge) {
     throw new Error("No challenge received");
   }
   const challenge = challengeData.challenge;
-  // 1.2. find the user's credentialId in local storage
-  const credentialId =
-    (await options.storage?.getPasskeyCredentialId()) ?? undefined;
-
   // 2. initiate login
   const authentication = await options.passkeyClient.authenticate({
-    credentialId,
+    credentialId: credentialId ?? undefined,
     challenge,
     rp: options.rp,
   });