You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces functionality for managing a MintFeeManager and a Multisig contract within the thirdweb framework, enhancing contract deployment and address prediction features.
Detailed summary
Added getPredictedMintFeeManagerAddress and getPredictedMultisigAddress functions.
Updated TemplateValue to include mintFeeManager and multisig addresses.
Integrated mint fee manager and multisig deployment in the contract deployment process.
Enhanced hooks to fetch mintFeeManager and multisig addresses.
Implemented address prediction for mint fee manager and multisig in utility functions.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Your org has enabled the Graphite merge queue for merging into main
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
DashboardInvolves changes to the Dashboard.DO NOT MERGEThis pull request is still in progress and is not ready to be merged.packages
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kumaryash90
requested review from
jnsdls,
MananTank,
joaquim-verges and
gregfromstl
as code owners
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces functionality for managing a
MintFeeManagerand aMultisigcontract within the thirdweb framework, enhancing contract deployment and address prediction features.Detailed summary
getPredictedMintFeeManagerAddressandgetPredictedMultisigAddressfunctions.TemplateValueto includemintFeeManagerandmultisigaddresses.mintFeeManagerandmultisigaddresses.