Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next15 #5152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

next15 #5152

wants to merge 1 commit into from

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR primarily focuses on updating various components and functions to use async/await for cookie management and parameter retrieval, improving consistency and readability across the codebase.

Detailed summary

  • Updated cookie retrieval to use await for consistency.
  • Changed function signatures to return Promise for parameters in multiple components.
  • Modified various components to handle async logic properly.
  • Adjusted imports to include JSX type where necessary.
  • Enhanced error handling by ensuring proper redirects and notFound calls.

The following files were skipped due to too many changes: apps/dashboard/src/app/layout.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/account/page.tsx, apps/portal/mdx-components.tsx, apps/dashboard/src/app/api/lib/getAuthToken.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/embed/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/analytics/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/account-abstraction/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/engine/(instance)/[engineId]/page.tsx, apps/dashboard/src/app/(dashboard)/contracts/deploy/[compiler_uri]/page.tsx, apps/playground-web/src/app/connect/sign-in/button/page.tsx, apps/dashboard/src/app/api/contact-us/route.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/_utils/getContractFromParams.ts, apps/dashboard/src/app/api/testnet-faucet/can-claim/route.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/tx/[txHash]/page.tsx, apps/dashboard/src/components/buttons/MismatchButton.tsx, apps/wallet-ui/src/app/[ecosystem]/(authed)/wallet/[address]/layout.tsx, apps/dashboard/src/app/login/auth-actions.ts, apps/dashboard/src/app/(dashboard)/trending/page.tsx, apps/dashboard/src/app/(dashboard)/support/create-ticket/components/create-ticket.client.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/account-abstraction/[clientId]/page.tsx, apps/wallet-ui/package.json, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/analytics/page.tsx, apps/dashboard/src/app/(dashboard)/explore/[category]/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/layout.tsx, apps/dashboard/src/app/api/testnet-faucet/claim/route.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/layout.tsx, apps/playground-web/package.json, apps/dashboard/src/app/(dashboard)/contracts/publish/[publish_uri]/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/chainlist/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/page.tsx, packages/thirdweb/package.json, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/page.tsx, apps/playground-web/src/app/connect/auth/server/actions/auth.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/popular/page.tsx, apps/portal/package.json, apps/portal/src/app/references/components/TDoc/PageLayout.tsx, apps/dashboard/package.json, apps/dashboard/src/app/(dashboard)/(chain)/chainlist/[chain_type]/page.tsx, apps/portal/src/app/typescript/v5/supported-wallets/[walletId]/page.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 344ab74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 1:17pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 1:17pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 1:17pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 1:17pm

Copy link

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 24, 2024 — with Graphite App
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages labels Oct 24, 2024
@jnsdls jnsdls marked this pull request as ready for review October 24, 2024 01:48
Copy link
Member Author

jnsdls commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, network, shell +74 5.98 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, network, shell +81 6.26 MB aws-sdk-bot
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, network, shell +76 4.95 MB aws-sdk-bot
npm/@hookform/[email protected] None 0 712 kB bluebill1049
npm/@next/[email protected] Transitive: environment, filesystem, network, shell +18 2.31 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected] Transitive: filesystem +18 587 kB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected] Transitive: filesystem, network +1 238 kB matt.straka, rauchg, timer, ...2 more
npm/[email protected] Transitive: environment, eval, filesystem, unsafe +159 15.1 MB timer, timneutkens, vercel-release-bot
npm/[email protected] Transitive: environment, filesystem, shell +49 14.9 MB react-bot
npm/[email protected] None 0 110 kB guilhermerodz
npm/[email protected] environment, eval Transitive: filesystem, shell, unsafe +86 11.8 MB webpro
npm/[email protected] environment, filesystem, network, shell, unsafe +13 122 MB vercel-release-bot
npm/[email protected] environment +1 6.45 MB fb, gnoff, react-bot, ...2 more
npm/[email protected] environment 0 239 kB react-bot
npm/[email protected] environment +39 10.9 MB arcthur, ckifer, nikolasrieble
npm/[email protected] network Transitive: environment +7 14.8 MB jmoxey

🚮 Removed packages: npm/@aws-sdk/[email protected], npm/@aws-sdk/[email protected], npm/@aws-sdk/[email protected], npm/@hookform/[email protected], npm/@next/[email protected], npm/@next/[email protected], npm/@next/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Oct 24, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.93 KB (-0.17% 🔽) 859 ms (-0.17% 🔽) 3.5 s (+17.49% 🔺) 4.4 s
thirdweb (cjs) 102.92 KB (+0.02% 🔺) 2.1 s (+0.02% 🔺) 5.5 s (-0.96% 🔽) 7.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 213 ms (-46.41% 🔽) 310 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 95 ms (+45.16% 🔺) 105 ms
thirdweb/react (minimal + tree-shaking) 17.37 KB (-0.11% 🔽) 348 ms (-0.11% 🔽) 606 ms (+31.74% 🔺) 953 ms

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (686d0c3) to head (344ab74).

Files with missing lines Patch % Lines
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5152   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1068     1068           
  Lines       55380    55380           
  Branches     3975     3976    +1     
=======================================
  Hits        25082    25082           
  Misses      29606    29606           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 686d0c3
packages 40.30% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 1.09% <ø> (ø)
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 1.34% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant