Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Feature: update batch metadata for NFT Drop #5175

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 25, 2024

image.png

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:31am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:31am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:31am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:31am

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 08:35 Inactive
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 9f1dbb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 25, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (b5bbecd) to head (9f1dbb8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5175   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3970     3970           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b5bbecd
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@kien-ngo kien-ngo force-pushed the kien/add-update-batch-base-ui branch from 2c180e3 to 2622379 Compare October 25, 2024 08:37
@kien-ngo kien-ngo changed the title Update [Dashboard] Feature: update batch metadata for NFT Drop Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 487 ms (+21.99% 🔺) 1.4 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.3 s (-9.29% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 25 ms (-73.18% 🔽) 122 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 120 ms (+341.74% 🔺) 130 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 256 ms (+97.48% 🔺) 602 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant