Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix explorer functions #6352

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Feb 26, 2025

TOOL-3534


PR-Codex overview

This PR focuses on cleaning up the filtering logic for functionsWithExtension in the contract-function.tsx file. It simplifies the code by removing redundant filters for specific function names.

Detailed summary

  • Removed multiple .filter() calls for specific function names from fnsOrEvents.
  • Simplified the assignment of allFunctions to a single .filter() call that checks for the type of function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners February 26, 2025 16:38
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: a26b266

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 5:19pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 26, 2025 5:19pm
login ⬜️ Skipped (Inspect) Feb 26, 2025 5:19pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 26, 2025 5:19pm
wallet-ui ⬜️ Skipped (Inspect) Feb 26, 2025 5:19pm

Copy link

graphite-app bot commented Feb 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.56 KB (0%) 932 ms (0%) 538 ms (+43.62% 🔺) 1.5 s
thirdweb (cjs) 124.25 KB (0%) 2.5 s (0%) 954 ms (+1.01% 🔺) 3.5 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 109 ms (+282.05% 🔺) 221 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 40 ms (+92.68% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 153 ms (+33.96% 🔺) 540 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 17:12 Inactive
@jnsdls jnsdls merged commit 3f6d525 into main Feb 26, 2025
28 of 29 checks passed
@jnsdls jnsdls deleted the yash/enable-explorer-functions branch February 26, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants