Use constant instead of static property

thirtybees · Dec 19, 2022 · 94640ac · 94640ac
1 parent 2bb7a30
commit 94640ac
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/blockcontactinfos.php b/blockcontactinfos.php
@@ -32,7 +32,7 @@ class Blockcontactinfos extends Module
     /**
      * @var string[]
      */
-    protected static $contact_fields = [
+    const CONTACT_FIELDS = [
         'BLOCKCONTACTINFOS_COMPANY',
         'BLOCKCONTACTINFOS_ADDRESS',
         'BLOCKCONTACTINFOS_PHONE',
@@ -83,7 +83,7 @@ public function install()
      */
     public function uninstall()
     {
-        foreach (Blockcontactinfos::$contact_fields as $field) {
+        foreach (static::CONTACT_FIELDS as $field) {
             Configuration::deleteByName($field);
         }
         return (parent::uninstall());
@@ -98,7 +98,7 @@ public function getContent()
     {
         $html = '';
         if (Tools::isSubmit('submitModule')) {
-            foreach (Blockcontactinfos::$contact_fields as $field) {
+            foreach (static::CONTACT_FIELDS as $field) {
                 Configuration::updateValue($field, Tools::getValue($field), true);
             }
             $this->_clearCache('blockcontactinfos.tpl');
@@ -124,7 +124,7 @@ public function hookHeader()
     public function hookFooter($params)
     {
         if (!$this->isCached('blockcontactinfos.tpl', $this->getCacheId())) {
-            foreach (Blockcontactinfos::$contact_fields as $field) {
+            foreach (static::CONTACT_FIELDS as $field) {
                 $this->smarty->assign(strtolower($field), Configuration::get($field));
             }
         }
@@ -191,7 +191,7 @@ public function renderForm()
             'languages' => $controller->getLanguages(),
             'id_language' => $this->context->language->id
         ];
-        foreach (Blockcontactinfos::$contact_fields as $field) {
+        foreach (static::CONTACT_FIELDS as $field) {
             $helper->tpl_vars['fields_value'][$field] = Tools::getValue($field, Configuration::get($field));
         }
         return $helper->generateForm([$fields_form]);