Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resulting names when first name has spaces #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xeroday
Copy link

@Xeroday Xeroday commented Jul 18, 2018

When the (first) name of generated output has spaces, the result is invalid.

Here's an example:
{"name":"","surname":"María Carmen Rodríguez","gender":"female","region":"Spain"}

The name (which was originally 'María Carmen') is empty and instead put into the surname.

Other examples that currently break:
Name: "A B", Surname: "C"
Current: Name: "", Surname: "A B C"

Name: "A B C", Surname: "D"
Current: Name: "A", Surname: "B C D"

Name: "A B C", Surname: "D E"
Current: Name: "A", Surname: "B C D E"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant