Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to System.Drawing for cross-platform compatibility #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

philippjbauer
Copy link

System.Drawing is only supported in Windows environments.

This PR replaced the Color class from System.Drawing with a standalone implementation and removes the System.Drawing usings.

The IDE formatted some code that slipped into the PR.

System.Drawing is only supported in Windows environments. Replaced the Color class from System.Drawing with a standalone implementation.
@thomasjo
Copy link
Owner

@philippjbauer This is awesome stuff, thanks!

I haven't had time to test this out yet, in part because I don't work with .NET these days and haven't got a dev environment readily available. Unfortunately, I haven't got CI/CD setup for this project, and the test suite is severely lacking anyway, which means both testing and pushing a new release to NuGet will have to be done manually 😞

Before I get around to testing and releasing a new version, do you think you could push a commit that ensures the code matches the existing formatting? That saves me from having to do it myself, but if you haven't got the time or interest I can take care of it — no worries 😄

Thanks again for helping out this weird, little project!

@thomasjo thomasjo self-assigned this Jan 22, 2024
@philippjbauer
Copy link
Author

Hey @thomasjo,

glad to help out. I got quite busy with other responsibilities and don't have time for it unfortunately.

@horvay
Copy link

horvay commented Oct 1, 2024

I guess it never got pushed, eh? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants