Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase buffer size for writing in btree serialized store #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase buffer size for writing in btree serialized store #273

wants to merge 1 commit into from

Conversation

freekvw
Copy link
Collaborator

@freekvw freekvw commented Aug 13, 2024

No description provided.

antialize
antialize requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@antialize antialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serialized_store has a default move constructor. So this approach will not work, since the pointer to the buffer will be invalid after the move. Either the backing should be turned into a vec, or we need to update the rd_buff on move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antialize antialize antialize requested changes

Assignees

@antialize antialize

@freekvw freekvw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freekvw @antialize