Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: threatstack/threatstack-puppet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0
Choose a base ref
...
head repository: threatstack/threatstack-puppet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Feb 7, 2019

  1. created auditd test branch

    nate st. germain committed Feb 7, 2019
    Copy the full SHA
    7c70ebf View commit details
  2. don't reassign that variable

    nate st. germain committed Feb 7, 2019
    Copy the full SHA
    252deca View commit details
  3. move that down a bit in the case statements

    nate st. germain committed Feb 7, 2019
    Copy the full SHA
    12903cb View commit details

Commits on Feb 8, 2019

  1. fix amazon linux repo url and auditd disabling

    nate st. germain committed Feb 8, 2019
    Copy the full SHA
    7386aa3 View commit details
  2. updated spec for yum/amazon test

    nate st. germain committed Feb 8, 2019
    Copy the full SHA
    38bf119 View commit details
  3. use old style os fact

    nate st. germain committed Feb 8, 2019
    Copy the full SHA
    5233479 View commit details
  4. ensure facts are in specs

    nate st. germain committed Feb 8, 2019
    Copy the full SHA
    b5c183f View commit details
  5. wow, okay. missed another spot.

    nate st. germain committed Feb 8, 2019
    Copy the full SHA
    96b9051 View commit details

Commits on Feb 11, 2019

  1. disable auditd on rhel like oses

    nate st. germain committed Feb 11, 2019
    Copy the full SHA
    ef52dfe View commit details
  2. don't set param twice

    nate st. germain committed Feb 11, 2019
    Copy the full SHA
    75674c0 View commit details

Commits on Feb 12, 2019

  1. updated readme and changelog

    nate st. germain committed Feb 12, 2019
    Copy the full SHA
    e80715f View commit details
  2. updated metadata

    nate st. germain committed Feb 12, 2019
    Copy the full SHA
    73446f5 View commit details
  3. Auditd fix (#34)

    * created auditd test branch
    
    * don't reassign that variable
    
    * move that down a bit in the case statements
    
    * fix amazon linux repo url and auditd disabling
    
    * updated spec for yum/amazon test
    
    * use old style os fact
    
    * ensure facts are in specs
    
    * wow, okay. missed another spot.
    
    * disable auditd on rhel like oses
    
    * don't set param twice
    
    * updated readme and changelog
    
    * updated metadata
    rockpapergoat authored Feb 12, 2019
    Copy the full SHA
    cbdfcda View commit details
  4. Merge remote-tracking branch 'origin/auditd_fix'

    nate st. germain committed Feb 12, 2019
    Copy the full SHA
    2d16dd3 View commit details

Commits on Feb 22, 2019

  1. Merge remote-tracking branch 'upstream/master'

    nate st. germain committed Feb 22, 2019
    Copy the full SHA
    c8f4480 View commit details
  2. Amazon 1 tests (#35)

    * created auditd test branch
    
    * don't reassign that variable
    
    * move that down a bit in the case statements
    
    * fix amazon linux repo url and auditd disabling
    
    * updated spec for yum/amazon test
    
    * use old style os fact
    
    * ensure facts are in specs
    
    * wow, okay. missed another spot.
    
    * disable auditd on rhel like oses
    
    * don't set param twice
    
    * updated readme and changelog
    
    * updated metadata
    
    * fix amazon linux 1 compatibility
    
    * fix style
    
    * make sure debian has this param defined, just in case
    
    * fix amazon linux 1 spec tests
    
    * fact wasn't defined
    
    * and another one
    
    * updated changelog, readme
    rockpapergoat authored Feb 22, 2019
    Copy the full SHA
    08962c5 View commit details
  3. Merge remote-tracking branch 'upstream/master'

    nate st. germain committed Feb 22, 2019
    Copy the full SHA
    3eae8c5 View commit details

Commits on Oct 16, 2019

  1. updated gitignore

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    45c8190 View commit details
  2. adding windows support

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    380ba09 View commit details
  3. added windows specific paths

    we shall see
    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    3edd43c View commit details
  4. don't reassign variables

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    8936878 View commit details
  5. missing a comma

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    50e91db View commit details
  6. make sure vars are defined

    clean this up later. we don't need to define some of those for windows,
    like gpg key and friends.
    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    bb90253 View commit details
  7. define another thing we don't need here.

    just want to test basic functionality.
    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    441485f View commit details
  8. fix missing brace

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    8c5b3f6 View commit details
  9. allow upgrades

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    ede1c2a View commit details
  10. ensure installed only for now

    nate st. germain committed Oct 16, 2019
    Copy the full SHA
    46135d9 View commit details

Commits on Oct 17, 2019

  1. skip configure hile testing

    but get back to it
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    b2aac9f View commit details
  2. wrong function there

    man, i'm rusty.
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    ed1cd8f View commit details
  3. use lwf/remote_file to download

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    d5f6a60 View commit details
  4. missing comma

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    803d3ca View commit details
  5. more typos

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    f12b3aa View commit details
  6. add bin paths for windows

    see if config works
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    47e5d9c View commit details
  7. trying another thing here

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    46059b9 View commit details
  8. added more params

    made config do less on windows
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    f33801e View commit details
  9. diff default ruleset for windows

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    72d6b0e View commit details
  10. pass deploy key from top level

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    26ea401 View commit details
  11. append the deploy key to the windows install opts

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    eec1389 View commit details
  12. apparently order is important here

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    709f1ce View commit details
  13. ensure the package resource is named correctly on windows

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    3d68a84 View commit details
  14. use the name reported by add/remove programs/registry

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    1ca6978 View commit details
  15. updated docs a little

    will have to go back to add new params, etc.
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    8c8e89c View commit details
  16. add windows data yaml

    will also need to flesh this out some
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    7ac2664 View commit details
  17. adding basic Windows agent support (#38)

    * created auditd test branch
    
    * don't reassign that variable
    
    * move that down a bit in the case statements
    
    * fix amazon linux repo url and auditd disabling
    
    * updated spec for yum/amazon test
    
    * use old style os fact
    
    * ensure facts are in specs
    
    * wow, okay. missed another spot.
    
    * disable auditd on rhel like oses
    
    * don't set param twice
    
    * updated readme and changelog
    
    * updated metadata
    
    * updated gitignore
    
    * adding windows support
    
    * added windows specific paths
    
    we shall see
    
    * don't reassign variables
    
    * missing a comma
    
    * make sure vars are defined
    
    clean this up later. we don't need to define some of those for windows,
    like gpg key and friends.
    
    * define another thing we don't need here.
    
    just want to test basic functionality.
    
    * fix missing brace
    
    * allow upgrades
    
    * ensure installed only for now
    
    * skip configure hile testing
    
    but get back to it
    
    * wrong function there
    
    man, i'm rusty.
    
    * use lwf/remote_file to download
    
    * missing comma
    
    * more typos
    
    * add bin paths for windows
    
    see if config works
    
    * trying another thing here
    
    * added more params
    
    made config do less on windows
    
    * diff default ruleset for windows
    
    * pass deploy key from top level
    
    * append the deploy key to the windows install opts
    
    * apparently order is important here
    
    * ensure the package resource is named correctly on windows
    
    * use the name reported by add/remove programs/registry
    
    * updated docs a little
    
    will have to go back to add new params, etc.
    
    * add windows data yaml
    
    will also need to flesh this out some
    rockpapergoat authored Oct 17, 2019
    Copy the full SHA
    3422d34 View commit details
  18. Merge remote-tracking branch 'origin/windows'

    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    c0428a0 View commit details
  19. remove hiera.yaml (don't think it's needed)

    and update gemfile with rest-client version
    nate st. germain committed Oct 17, 2019
    Copy the full SHA
    369e9cc View commit details

Commits on Oct 18, 2019

  1. update metadata

    nate st. germain committed Oct 18, 2019
    Copy the full SHA
    c29b691 View commit details

Commits on Oct 21, 2019

  1. test adding sysmon on windows

    nate st. germain committed Oct 21, 2019
    Copy the full SHA
    5d0f7fe View commit details

Commits on Oct 22, 2019

  1. add archive module as a dependency

    nate st. germain committed Oct 22, 2019
    Copy the full SHA
    4209b15 View commit details
  2. only download if the file doesn't exist

    nate st. germain committed Oct 22, 2019
    Copy the full SHA
    600f6c1 View commit details
7 changes: 7 additions & 0 deletions .fixtures.yml
Original file line number Diff line number Diff line change
@@ -5,3 +5,10 @@ fixtures:
stdlib: "puppetlabs/stdlib"
apt: "puppetlabs/apt"
translate: "puppetlabs/translate"
auditd: "simp/auditd"
simplib: "simp/simplib"
augeas_core: "herculesteam/augeasproviders_core"
augeaslibs: "herculesteam/augeasproviders_grub"
archive: "puppet/archive"
remote_file: "lwf/remote_file"
concat: "puppetlabs/concat"
9 changes: 9 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
.DS_Store
.kitchen/
.bundle
.kitchen.local.yml
.librarian/
*.swp
*.orig
*.log
*.rpm
*.deb
.ruby-version
.tmp/
.vagrant
config.sh
test.pp
modules/
pkg
Gemfile.lock
188 changes: 181 additions & 7 deletions .kitchen.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
---
driver:
name: vagrant
name: docker

provisioner:
name: puppet_apply
modules_path: modules
manifests_path: manifests
ignore_spec_fixtures: true
<% if ENV['PUPPET3'] != nil %>
require_puppet_collections: false
<% else %>
@@ -21,16 +22,189 @@ provisioner:
ts_package_version: <%= ENV['TS_PACKAGE_VERSION'] %>
<% end %>

transport:
name: ssh
max_ssh_sessions: 1

platforms:
- name: centos-6.7
- name: centos-7.3
- name: debian-7.8
- name: fedora-25
- name: ubuntu-12.04
- name: ubuntu-14.04
- name: amazon-1
driver_config:
image: amazonlinux:1
platform: amazonlinux
run_command: /sbin/init
privileged: true
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- yum install -y audit initscripts
- sed -i 's/local_events = yes/local_events = no/g' /etc/audit/auditd.conf
- chkconfig auditd on
- name: amazon-2
driver_config:
image: amazonlinux:2
platform: amazonlinux
run_command: /sbin/init
privileged: true
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- yum install -y audit initscripts
- sed -i 's/local_events = yes/local_events = no/g' /etc/audit/auditd.conf
- systemctl enable auditd.service
- name: centos-7
driver_config:
image: centos:7
run_command: /sbin/init
cap_add:
- SYS_ADMIN
privileged: true
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- yum install -y audit initscripts
- sed -i 's/local_events = yes/local_events = no/g' /etc/audit/auditd.conf
- systemctl enable auditd.service
- name: centos-8
driver_config:
image: centos:8
run_command: /sbin/init
cap_add:
- SYS_ADMIN
privileged: true
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- yum install -y audit initscripts
- sed -i 's/local_events = yes/local_events = no/g' /etc/audit/auditd.conf
- systemctl enable auditd.service
- name: centos-8-arm
provisioner:
puppet_yum_collections_repo: https://yum.puppet.com/puppet/puppet-release-el-8.noarch.rpm
driver_config:
image: arm64v8/centos:8
run_command: /sbin/init
cap_add:
- SYS_ADMIN
privileged: true
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- yum install -y audit initscripts
- sed -i 's/local_events = yes/local_events = no/g' /etc/audit/auditd.conf
- systemctl enable auditd.service
- name: debian-8
driver_config:
image: debian:8
run_command: /sbin/init
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service
- name: debian-9
provisioner:
puppet_apt_collections_repo: http://apt.puppetlabs.com/puppet7-release-stretch.deb
driver_config:
image: debian:9
run_command: /bin/systemd
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service
- name: debian-10
driver_config:
image: debian:10
run_command: /sbin/init
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service
- name: ubuntu-16.04
driver_config:
image: ubuntu:16.04
run_command: /sbin/init
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service
- name: ubuntu-18.04
driver_config:
image: ubuntu:18.04
run_command: /sbin/init
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service
- name: ubuntu-20.04
provisioner:
puppet_apt_collections_repo: https://apt.puppetlabs.com/puppet7-release-focal.deb
driver_config:
image: ubuntu:20.04
run_command: /sbin/init
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service
- name: ubuntu-20.04-arm
provisioner:
puppet_apt_collections_repo: https://apt.puppetlabs.com/puppet7-release-focal.deb
driver_config:
image: arm64v8/ubuntu:20.04
run_command: /sbin/init
cap_add:
- SYS_ADMIN
run_options:
env: container=docker
volume:
- /sys/fs/cgroup:/sys/fs/cgroup
provision_command:
- sed -i 's/UsePAM yes/UsePAM no/g' /etc/ssh/sshd_config
- systemctl enable ssh.service

suites:
- name: default
provisioner:
manifest: site.pp
- name: custom
provisioner:
manifest: site.pp
facter_file: test/data/test_custom_fact.rb
5 changes: 4 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
language: ruby
rvm:
- 2.5
before_install:
- curl https://apt.puppetlabs.com/DEB-GPG-KEY-puppet | sudo apt-key add -
- curl -O https://apt.puppetlabs.com/puppet5-release-trusty.deb
- sudo dpkg -i puppet5-release-trusty.deb
- sudo apt-get update -q
- sudo apt-get install -y lsb-release puppet-agent
- /opt/puppetlabs/puppet/bin/gem install bundler
- /opt/puppetlabs/puppet/bin/gem install bundler rake
- gem install bundler rake
bundler_args: "--without system_tests"
before_script:
- export PATH=$PATH:/opt/puppetlabs/puppet/bin
46 changes: 46 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,52 @@

We'll track changes here starting with details about the 2.0 release and reference to earlier releases.

## 2.0.11
- switched to using [simp/auditd](https://forge.puppet.com/modules/simp/auditd) to deal with `auditd`
- the [kemra102/auditd](https://forge.puppet.com/modules/kemra102/auditd) module appears to be abandoned and doesn't support RHEL 8

## 2.0.10
### Added
- updated README with support for
- Debian 10
- Ubuntu 20.04
- CentOS/RedHat 8
- updated tests for newer distros
- added optional parameter to enable/disable yum repo on rhel

## 2.0.9
### Fixed
- merged PR simplifying ruleset args
- https://github.com/threatstack/threatstack-puppet/pull/47

## 2.0.8
### Fixed
- merged PR fixing amazon linux 1/upstart service compatibility
- also uses `remote_file` vs. `file` resource in windows manifest
- https://github.com/threatstack/threatstack-puppet/pull/45
- merged PR defaulting to default apt keyserver
- https://github.com/threatstack/threatstack-puppet/pull/46
- thanks @carthik and @amlodzianowski!

## 2.0.7
### Changed
- use a service resource to manage auditd vs. an exec

## 2.0.6
### Added
- added basic support for downloading, configuring, installing, running windows agent

## 2.0.2
### Fixed
- fixed amazon linux 1 support and tests

## 2.0.1
### Changed
- added optional parameter `disable_auditd` to handle issues users reported installing on RHEL-like OSes

### Fixed
- fixed amazon linux 2 yum repo assignment

## 2.0
### This release tracks the release of the Threat Stack Agent 2.0

11 changes: 11 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Contributing to Threat Stack Agent Puppet Module
=============================

We encourage anyone to provide enchancements/fixes to this repository. Simply fork, commit, and then open a PR back to the parent repository.


### What makes a good PR?

* Make sure you update the README.md with any new/removed/changed values parameters.
* Write tests that cover your proposed changes.
* Make sure the tests documented in the [README](README.md) run as expected on all platforms.
11 changes: 5 additions & 6 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
source 'https://rubygems.org'

source ENV['GEM_SOURCE'] || 'https://rubygems.org'

group :development, :unit_tests do
gem 'rake', :require => false
group :development, :unit_tests , :test do
gem 'rake', "13.0.1", :require => false
gem 'rspec-puppet', "2.7.2", :require => false
gem 'puppetlabs_spec_helper', :require => false
gem 'puppet-lint', "2.3.6", :require => false
@@ -14,15 +12,16 @@ group :development, :unit_tests do
gem 'metadata-json-lint', '2.2.0', :require => false
gem 'vagrant-wrapper', :require => false
gem 'puppet-blacksmith', :require => false
gem 'rest-client', ">=1.7.3", :require => false
gem 'rest-client', ">=1.8", :require => false
gem 'semantic_puppet', :require => false
gem 'rspec-puppet-facts', '~> 1.7', :require => false
end

group :system_tests do
gem 'serverspec', :require => false
gem 'test-kitchen', :require => false
gem 'kitchen-puppet', :require => false
gem 'kitchen-vagrant', :require => false
gem 'kitchen-docker', :require => false
end

if facterversion = ENV['FACTER_GEM_VERSION']
7 changes: 6 additions & 1 deletion Puppetfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Here for kitchen-puppet.
forge "https://forgeapi.puppetlabs.com"

mod 'puppetlabs-stdlib'
mod 'puppetlabs-stdlib', '4.20.0'

mod 'puppetlabs-apt', '6.2.1'
mod 'lwf-remote_file', '1.1.3'
mod 'puppet-archive', '4.3.0'
mod 'simp-auditd', '8.6.1'
Loading