Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run postinstall script separately from yarn install #531

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Don't run postinstall script separately from yarn install #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/dashboard-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ jobs:
run: git config --global url."https://".insteadOf git://

- name: Install dependencies
run: yarn install --ignore-scripts --frozen-lockfile

- name: Run token-dashboard post-install script
run: yarn run postinstall
run: yarn install --frozen-lockfile

- name: Check formatting
run: yarn format
Expand Down Expand Up @@ -80,7 +77,7 @@ jobs:
@keep-network/tbtc-v2 \
@keep-network/tbtc-v2.ts \
@keep-network/ecdsa \
@keep-network/random-beacon --ignore-scripts
@keep-network/random-beacon

- name: Run postinstall script
# `yarn upgrade` doesn't trigger the `postinstall` script.
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/dashboard-mainnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ jobs:
run: git config --global url."https://".insteadOf git://

- name: Install dependencies
run: yarn install --ignore-scripts --frozen-lockfile

- name: Run token-dashboard post-install script
run: yarn run postinstall
run: yarn install --frozen-lockfile

# FIXME: It's work in progress, the contracts are not yet published.
# - name: Resolve latest mainnet contracts
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/reusable-build-and-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ jobs:

- name: Install dependencies
shell: bash
run: yarn install --ignore-scripts --frozen-lockfile

- name: Run token-dashboard post-install script
shell: bash
run: yarn run postinstall
run: yarn install --frozen-lockfile

- name: Get upstream packages versions
if: inputs.useUpstreamBuilds == true
Expand Down