Fix an issue where policies built with LRSchedulerFactoryLinear were not picklable #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return LambdaLR(optim, lr_lambda=lambda epoch: 1 - epoch / max_update_num) | ||
| return LambdaLR(optim, lr_lambda=self._LRLambda(self.sampling_config).compute) | ||
|
|
||
| class _LRLambda: |
There was a problem hiding this comment.
imo you can define a function instead of creating a temporary class
There was a problem hiding this comment.
The class is there to cache the second parameter of the function (max_update_num).
Trinkle23897
previously approved these changes
Nov 14, 2023
Trinkle23897
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make format(required)make commit-checks(required)The cause was the use of a lambda function in the state of a generated object.