Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch_size=None and use it in various scripts #993

Conversation

MischaPanch
Copy link
Collaborator

@MischaPanch MischaPanch commented Nov 16, 2023

Closes #986

@Trinkle23897 Trinkle23897 marked this pull request as ready for review November 24, 2023 17:57
Copy link
Collaborator

@Trinkle23897 Trinkle23897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, lgtm

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f134bc2) 88.11% compared to head (7c0fb33) 88.09%.

Files Patch % Lines
tianshou/data/buffer/base.py 75.00% 1 Missing ⚠️
tianshou/data/buffer/manager.py 80.00% 1 Missing ⚠️
tianshou/trainer/base.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   88.11%   88.09%   -0.02%     
==========================================
  Files          96       96              
  Lines        7514     7527      +13     
==========================================
+ Hits         6621     6631      +10     
- Misses        893      896       +3     
Flag Coverage Δ
unittests 88.09% <89.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trinkle23897 Trinkle23897 merged commit 8d3d1f1 into thu-ml:master Nov 24, 2023
5 checks passed
@Trinkle23897 Trinkle23897 deleted the refactoring/improve-batch-size-handling branch November 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better default for batch_size in examples
3 participants