Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style: add maven plugin and code style #165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

liukun4515
Copy link
Contributor

No description provided.

@liukun4515 liukun4515 requested a review from MyXOF October 12, 2018 09:39
pom.xml Outdated
</goals>
<configuration>
<encoding>UTF-8</encoding>
<configFile>${project.basedir}/eclipse-java-google-style.xml</configFile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkstyle文件对非eclipse的有效吗..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference formatter.

I use the eclipse-google-java-style.

If you want to format your code, just build the project (mvn compile or mvn package)

@jixuan1989
Copy link
Member

测试失败了...?

@liukun4515
Copy link
Contributor Author

liukun4515 commented Oct 12, 2018

PTAL @jixuan1989 @MyXOF

@liukun4515 liukun4515 added WIP work-in-progress DNM do-not-merge labels Oct 13, 2018
@liukun4515 liukun4515 removed DNM do-not-merge WIP work-in-progress labels Oct 13, 2018
@jixuan1989
Copy link
Member

PTAL @jixuan1989 @MyXOF

你实习后,最明显的长进就是缩写变潮了

Copy link
Member

@jixuan1989 jixuan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先不要format...
但是其他内容可以保留。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants