Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the ability to configure Azure OpenAI deployments. #7

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

ktooi
Copy link
Contributor

@ktooi ktooi commented Oct 5, 2023

Thank you for merging #6.

I wanted to deploy GPT-4 in Azure OpenAI, so I modified it.

If you have anything you want me to change, just ask and will do my best to accommodate such that it can be merged.

@thunderbug1 thunderbug1 merged commit 9f4f8c2 into thunderbug1:main Oct 5, 2023
@thunderbug1
Copy link
Owner

Thank you for merging #6.

I wanted to deploy GPT-4 in Azure OpenAI, so I modified it.

If you have anything you want me to change, just ask and will do my best to accommodate such that it can be merged.

Thank you for the PR.
PRs are always welcome, right now I don't really have the time to do much development on the project but there are some configs that are unused at the moment, see #3
If you want to do some work, that might be a good place to start ;)

@ktooi
Copy link
Contributor Author

ktooi commented Oct 6, 2023

Thank you for your confirmation and reply.
Regarding the unused Config, are you referring to AZURE_OPENAI_API_COMPLETIONS_DEPLOYMENT_NAME and AZURE_OPENAI_API_EMBEDDINGS_DEPLOYMENT_NAME?
I know these are not used, but I have fixed them for consistency.

This Terraform is important to me and I will continue to open PRs as needed 😄

@thunderbug1
Copy link
Owner

No, I think that DOCKER_REGISTRY_SERVER_URL has no effect.
It is not an issue but it may be confusing for people and potentially there are other unused parameters as well.
I never found the time to tidy things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants