Skip to content

Commit

Permalink
Disable VDDH check for nRF52833/40 boards unless explicitly enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
gfwilliams committed Mar 19, 2024
1 parent 805c317 commit 55fbab3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions README_BuildProcess.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ This is a partial list of definitions that can be added in a `BOARD.py` file's `
* `ESPR_DCDC_ENABLE=1` - On NRF52 use the built-in DCDC converter (requires external hardware)
* `ESPR_DCDC_HV_ENABLE=1` - On NRF52840 use the built-in high-voltage (REG0) DCDC converter (requires external hardware)
* `ESPR_REGOUT0_1_8V=1` - On NRF52830/40 set the REG0 VCC voltage to 1.8v (the default is 3.3v)
* `ESPR_VREF_VDDH=1` - when measuring system voltage (eg for E.getAnalogVRef()) use VDDH, not VDD (only useful if DCDC_HV enabled)
* `ESPR_LSE_ENABLE` - On NRF52 use an external 32kHz Low Speed External crystal on D0/D1
* `ESPR_NO_LOADING_SCREEN` - Bangle.js, don't show a 'loading' screen when loading a new app
* `ESPR_BOOTLOADER_SPIFLASH` - Allow bootloader to flash direct from a file in SPI flash storage
Expand Down
3 changes: 0 additions & 3 deletions targets/nrf5x/jshardware.c
Original file line number Diff line number Diff line change
Expand Up @@ -2818,9 +2818,6 @@ JsVarFloat jshReadVRef() {
config.gain = NRF_SAADC_GAIN1_6; // 1/6 of input volts
config.mode = NRF_SAADC_MODE_SINGLE_ENDED;

#if defined(NRF52833) || defined(NRF52840) && !defined(BANGLEJS2)
#define ESPR_VREF_VDDH
#endif
#ifdef ESPR_VREF_VDDH
config.pin_p = 0x0D; // Not in Nordic's libs, but this is VDDHDIV5 - we probably want to be looking at VDDH
config.pin_n = 0x0D;
Expand Down

0 comments on commit 55fbab3

Please sign in to comment.