Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use platform for id #655

Merged
merged 4 commits into from
Apr 7, 2024
Merged

chore: use platform for id #655

merged 4 commits into from
Apr 7, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Apr 7, 2024

allows you to use platform="android" for <id>

Tested on Linux/Andorid with:

	<id platform="android">com.miga.test_android</id>
	<id>com.miga.test</id>

and

	<id>com.miga.test</id>
	<id platform="android">com.miga.test_android</id>

both time it will use com.miga.test_android at the end.

TODO
Need to check it on iOS

lib/tiappxml.js Outdated Show resolved Hide resolved
lib/tiappxml.js Outdated Show resolved Hide resolved
lib/tiappxml.js Outdated Show resolved Hide resolved
lib/tiappxml.js Outdated Show resolved Hide resolved
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m1ga
Copy link
Contributor Author

m1ga commented Apr 7, 2024

tests will fail. Fixed them in the other PR: #653

@cb1kenobi cb1kenobi merged commit 4cfd5cd into master Apr 7, 2024
1 of 2 checks passed
@m1ga m1ga deleted the chorePlatformId branch April 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants