feat: make undistort algorithm configurable #3
Conversation
seixasxbr
force-pushed
the
undistort-param
branch
from
a701038 to
d31f478
Compare
seixasxbr
force-pushed
the
undistort-param
branch
from
d31f478 to
10b7024
Compare
seixasxbr
force-pushed
the
undistort-param
branch
from
10b7024 to
755d7c7
Compare
seixasxbr
changed the title
|
Should this PR actually go to the main repository (once the related PR is merged)? |
| property("undistort_algorithm","/frame_helper/UndistortAlgorithm",:UNDISTORT_LINEAR). | ||
| doc "interpolation algorithm which is used to undistort the frame before it is written to the output port. " |
There was a problem hiding this comment.
strictly speaking the interpolation isn't the undirstor algorithm, it is a piece of it
| property("undistort_algorithm","/frame_helper/UndistortAlgorithm",:UNDISTORT_LINEAR). | |
| doc "interpolation algorithm which is used to undistort the frame before it is written to the output port. " | |
| property("undistort_interpolation","/frame_helper/UndistortAlgorithm",:UNDISTORT_LINEAR). | |
| doc "interpolation used by the undistort algorithm " |
There was a problem hiding this comment.
Right ... but then undistort_algorithm is what it's called in the frame helper implementation ... Is this worth having to change all of it ? Not sure personally.
| property("undistort_algorithm","/frame_helper/UndistortAlgorithm",:UNDISTORT_LINEAR). | ||
| doc "interpolation algorithm which is used to undistort the frame before it is written to the output port. " |
There was a problem hiding this comment.
Right ... but then undistort_algorithm is what it's called in the frame helper implementation ... Is this worth having to change all of it ? Not sure personally.
It should have been pointing to rock directly. Mateus will create a new PR to fix that. |
https://github.com/rock-drivers/drivers-orogen-camera_base/pull/12/files |
Depends on:
What is this PR for
make the interpolation method used to undistort the image configurable
review hint
The first commit is just indentation
Checklist