Merge pull request #291 from tidymodels/encodings

Fix encodings
tidymodels · Jan 10, 2024 · ebcfff8 · ebcfff8
2 parents 6f38052 + f4224f0
commit ebcfff8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -10,6 +10,8 @@
 
 * Bug fix for `multi_predict(type = "survival")` for `proportional_hazards(engine = "glmnet")` models: when used with a single `penalty` value, this value is now included in the results. It was previously omitted (#267, #282).
 
+* Bug fix: `proportional_hazards(engine = "glmnet")` models now don't pretend to be able to deal with sparse matrices when they are not (#291).
+
 
 # censored 0.2.0
 

diff --git a/R/bag_tree-data.R b/R/bag_tree-data.R
@@ -40,7 +40,7 @@ make_bag_tree_rpart <- function() {
     eng = "rpart",
     mode = "censored regression",
     options = list(
-      predictor_indicators = "traditional",
+      predictor_indicators = "none",
       compute_intercept = FALSE,
       remove_intercept = FALSE,
       allow_sparse_x = FALSE

diff --git a/R/proportional_hazards-data.R b/R/proportional_hazards-data.R
@@ -151,7 +151,7 @@ make_proportional_hazards_glmnet <- function() {
       predictor_indicators = "traditional",
       compute_intercept = TRUE,
       remove_intercept = TRUE,
-      allow_sparse_x = TRUE
+      allow_sparse_x = FALSE
     )
   )
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,6 +10,8 @@

		* Bug fix for `multi_predict(type = "survival")` for `proportional_hazards(engine = "glmnet")` models: when used with a single `penalty` value, this value is now included in the results. It was previously omitted (#267, #282).

		* Bug fix: `proportional_hazards(engine = "glmnet")` models now don't pretend to be able to deal with sparse matrices when they are not (#291).


		# censored 0.2.0

Expand Down