Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name backtick audit rsample #525

Merged

Conversation

agmurray
Copy link
Contributor

@agmurray agmurray commented Aug 15, 2024

closes #503

Several instances of packages found that were still backticked, mainly from NEWS file and a few others.

Fixes tidymodels#503
…re I inadvertantly deleted a word. Fixed and updated.
NEWS.md Outdated Show resolved Hide resolved
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's great! Could you please address the two small code comments?

R/make_strata.R Outdated Show resolved Hide resolved
vignettes/Working_with_rsets.Rmd Outdated Show resolved Hide resolved
@agmurray
Copy link
Contributor Author

I think I made the two edits... please let me know if I didn't. Thanks for all you all do for open source software and letting us continue to contribute in small ways!

@hfrick
Copy link
Member

hfrick commented Aug 23, 2024

@agmurray Thanks for the edits! I'm just dropping in quickly to say that I'm OOO until the week after next but will get to this after my return.

@hfrick hfrick merged commit 3b15c34 into tidymodels:main Sep 4, 2024
12 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit for backticked package names
3 participants