fix: obtain expected quantity values from manual scale #5364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the code and adds corresponding unit tests.
When using
manual_scale
to create adiscrete_scale
, thepalette
should be a function that can return the specified number ofvalues
when called with a single integer argument.Here is the parameter description excerpt from
scale-.R
:In the original
manual_scale
method, it simply returned all thevalues
. However, whenvalues
are not named, we only need to return the corresponding first 'n' values. Therefore, the modified code includes a condition to handle this case.