Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pack() and unpack() generic #1372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 10, 2022

Useful now that duckdb supports them with the DBI interface: duckdb/duckdb#3495.

@krlmlr krlmlr requested a review from DavisVaughan June 12, 2022 04:28
@krlmlr
Copy link
Member Author

krlmlr commented Jun 12, 2022

I wonder if we should instead define new generics build_pack_spec() and pack_spec(), similarly for "unpack". The DuckDB implementation is copying a bit of code from tidyr: duckdb/duckdb#3829.

@olivroy
Copy link
Contributor

olivroy commented Apr 4, 2024

I may be mistaken, but I think this would help separate_wider_delim() / separate_wider_regex() work with sf objects. Is there a plan to merge this PR? (r-spatial/sf#2359)

@elipousson
Copy link

Adding to @olivroy's comment, it would be great to see this PR reviewed and merged to support the implementation of separate_wider_delim() / separate_wider_regex() with sf.

I'm teaching sf to a graduate course this fall and seeing these functions silent dropping the sf class (when 90+% of tidyverse functions work seamlessly) is such a weird and potentially frustrating loophole!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants