give attribution to previous work in nc package #1474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! The new
separate_wider_regex
functions seems to be inspired by previous work in my namedCapture/nc packages, so I would suggest making it clear about where that idea comes from. At least in the academic/university, attribution is important so it would be useful for people to know/cite my related R Journal papers,https://journal.r-project.org/archive/2019/RJ-2019-050/index.html
https://journal.r-project.org/archive/2021/RJ-2021-029/index.html