Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give attribution to previous work in nc package #1474

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

tdhock
Copy link
Contributor

@tdhock tdhock commented Jan 24, 2023

Hi! The new separate_wider_regex functions seems to be inspired by previous work in my namedCapture/nc packages, so I would suggest making it clear about where that idea comes from. At least in the academic/university, attribution is important so it would be useful for people to know/cite my related R Journal papers,
https://journal.r-project.org/archive/2019/RJ-2019-050/index.html
https://journal.r-project.org/archive/2021/RJ-2021-029/index.html

@hadley
Copy link
Member

hadley commented Feb 6, 2023

I have no recollection of ever seeing that package, but the chances are I did, and I just don't remember it. So we should certainly include a nod to this package in the news file and the docs.

@tdhock
Copy link
Contributor Author

tdhock commented Feb 6, 2023

thanks!

@hadley hadley merged commit c9ca3cf into tidyverse:main Nov 1, 2023
12 checks passed
@hadley
Copy link
Member

hadley commented Nov 1, 2023

I tweaked the language a bit since I think it's probably an example of convergent evolution, rather than a direct inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants