Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement future.apply in forecast.mdl_df #271

Merged
merged 3 commits into from
Sep 23, 2020
Merged

implement future.apply in forecast.mdl_df #271

merged 3 commits into from
Sep 23, 2020

Conversation

davidtedfordholt
Copy link
Contributor

@davidtedfordholt davidtedfordholt commented Sep 23, 2020 •
edited
Loading

As promised. I'm happy to use something other than the mapply for the non-future.apply implementation. This addresses issue #268

mitchelloharawild
mitchelloharawild requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@mitchelloharawild mitchelloharawild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

Could you add this to the NEWS as an Improvement, and add yourself to as ctb?

@davidtedfordholt
Copy link
Contributor Author

I just added a note to "performance enhancements," since this is just a specific instance of that.

mitchelloharawild
mitchelloharawild approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@mitchelloharawild mitchelloharawild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mitchelloharawild mitchelloharawild merged commit b24fe54 into tidyverts:master Sep 23, 2020
@davidtedfordholt davidtedfordholt deleted the parallel_forecasting branch September 23, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelloharawild mitchelloharawild mitchelloharawild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidtedfordholt @mitchelloharawild