Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify; Making timeout durationto be longer #125

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

TakahikoHasegawa97
Copy link

Depends on the location; places where we have low network connection would introduce some issue in connection loss between signage ECU and FMS. This could introduce some timeout in FMS thread.
Hence the increase in timout

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Read [commit-guidelines][commit-guidelines]
  • Assign PR to reviewer

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

@dkoldaev
Copy link

what happens if the timeout has passed?

@TakahikoHasegawa97
Copy link
Author

what happens if the timeout has passed?

FMS thread times out so the bus stop view will not be displayed and just shows Auto Mode

@dkoldaev
Copy link

so it does not retry and simply abandon the request?

@TakahikoHasegawa97 TakahikoHasegawa97 merged commit 745cdc2 into erga_isuzu Sep 30, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants