feat(aip_x2_gen2_launch): use downsample mask filter #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojomex
changed the title
kotaro-hihara
force-pushed
the
feat/use_downsample_mask_filter
branch
from
78681c8 to
d99b258
Compare
|
nebulaをmainブランチにしてlogging simulatorで動作確認しました。 left_upperのみfilterを変更してみて目視確認 one_third
two_thirds
full
|
|
(設定に問題はなさそうだが、画像だとtwo_thirdsよりone_thirdのほうが濃く見える不思議 🤔 ) |
|
@kotaro-hihara |
白部分がFOV有効、黒が無効部分で、one_thirdは1/3になるよう2/3削ってる(2/3が黒)ので画像のとおりです 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nebulaのdownsample_mask filterを使用するためにconfigを設定し直す。 JIRA
ring_section_filterのconfig yamlからconfig imageを生成
対応するnebulaのPR
ベンチ、LSIMで確認