Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_arbiter): add signal match validator (#6423) #1152

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Feb 20, 2024

Description

Cherry-pick this PR to enable the feature that validates the result of perception and external (V2I).

PR for launch

Related

TIER IV INTERNAL JIRA LINK

Tests performed

See autowarefoundation#6423

Effects on system behavior

If the traffic light recognition result and V2I result are not equivalent, it is published as UNKNOWN and the ego stops.
This feature is enabled by setting enable_signal_matching to true.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 44b619a into beta/v0.19.1 Feb 26, 2024
25 of 26 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/add-signal-match-validator branch February 26, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants