fix(pid_longitudinal_controller): fix the same point error (#8758) #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundation#8758) * fix same point Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
requested review from
soblin,
TakaHoribe and
takayuki5168
as code owners
|
TetsuKawa
pushed a commit
that referenced
this pull request
Jan 23, 2025
…oundation#8758) (#1512) * fix same point Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://tier4.atlassian.net/browse/RT0-33317 の修正PRです。
不具合は速度制御の勾配計算部分において発生しており、
same pointによる nanやゼロ割が発生し、その結果lpfがバグって復帰できない状態となっていました。
この修正により、当該rosbagで再現しないことと、無印でのシナリオテストに問題がないことを確認しました。
Related links
無印側修正 PR autowarefoundation#8758
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.