Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): stop point activated too early #986

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

zulfaqar-azmi-t4
Copy link

Description

cherry pick from autowarefoundation#5402

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title Fix lane change early execution fix(lane_change): stop point activated too early Oct 25, 2023
@takayuki5168 takayuki5168 marked this pull request as draft October 31, 2023 01:59
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the fix-lane-change-early-execution branch from 98dd92a to eba90c5 Compare November 2, 2023 03:21
…5402)

* fix(lane_change): stop point activated too early

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* refactor

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix dead node

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the fix-lane-change-early-execution branch from eba90c5 to 6bc5ab4 Compare November 2, 2023 04:48
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review November 2, 2023 04:49
@TomohitoAndo TomohitoAndo changed the base branch from beta/v0.11.0 to beta/v0.11.1 November 22, 2023 06:54
@TomohitoAndo TomohitoAndo requested a review from 0x126 November 22, 2023 06:55
@TomohitoAndo TomohitoAndo self-requested a review November 22, 2023 11:24
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126 0x126 merged commit 171d721 into beta/v0.11.1 Nov 22, 2023
12 checks passed
@0x126 0x126 deleted the fix-lane-change-early-execution branch November 22, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants