Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix container name handling #14

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 22, 2024

Description

LiDAR container name was not set properly.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda marked this pull request as ready for review January 22, 2024 01:41
@kminoda
Copy link
Contributor Author

kminoda commented Jan 22, 2024

@shmpwk Hi, would you review this PR? 🙏

@shmpwk shmpwk merged commit c698f24 into tier4:main Jan 22, 2024
8 of 10 checks passed
@kminoda kminoda deleted the fix/container_name_handling branch January 22, 2024 02:19
mitsudome-r pushed a commit to mitsudome-r/awsim_sensor_kit_launch that referenced this pull request Jan 23, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants