Feat/add generic velodyne decode fix/fix2 #165

ike-kazu · 2024-06-19T06:18:35Z

PR Type

New Feature
Improvement
Bug Fix

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
(Optional) Unit tests have been written for new behavior
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

…c-velodyne-decoder

ike-kazu · 2024-06-19T06:22:15Z

sorry i create this pr with my mistake

bgilby59 and others added 30 commits April 4, 2024 15:49

save progress (velodyne_generic_decoder.cpp logic done except unpack())

3519fe7

push combined vlp16/vls128 decoder for testing

2c20425

update templating and fix various bugs

27b9bf0

passes tests VLP16/VLS128 combined decoder

2515dba

remove generic decoder cpp file

e35819c

clean up files

2f665ed

better develop velodyne sensor classes

9d1e0fc

Merge remote-tracking branch 'tier4-nebula/main' into feat/add-generi…

ad90587

…c-velodyne-decoder

push VLP32 results *almost* identical to original decoder

2e4aab0

change floats to doubles

0195ef0

return to calculating ROI points based on corrected azimuth

8e8653a

adjust VLP32 laser azimuth cache calculation and add note

f499a96

fix timing offsets calculation

2b60694

update TODOs

83b3d68

fix get_pointcloud() (breaks vlp16 test)

4b02317

remove now unnecessary vlp32 decoder

7e99e13

remove old reference to vlp32 decoder from CMakeLists.txt

f35bf81

fix compiler warnings

d8b5b63

delete empty files

8417ef0

fix double into float for test

c528884

fix pointcloud number difference in test

d5fcf91

fix phase_diff for test

7395065

pass 32 test

5259d6f

fix spell miss in comment out

28b1f9f

add @brief and explain comments

00034f9

fix typo in comment

2d1ce68

fix typo in comments

cc06fdf

fix typo in comment

9dce585

create const pointsPerPacket

432f458

fix i-statement

284aa16

ike-kazu added 13 commits May 27, 2024 16:41

fix if_statement

a3367fe

add error handling

e5e8733

fix long into int

01f9051

move all sensor-specific constants to the respective sensor's file

9167b6d

Use memcpy

15ca9c7

create elodyne_packet.hpp

c631bea

add comment and take error

5aa8d18

delete submodule

d49ec05

fix @belief comment

1c703f7

fix raw_block

053cf71

add getBank function

14ff06f

delete include

4b20099

failed fixing packet stract refactoring

50f4543

ike-kazu closed this Jun 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add generic velodyne decode fix/fix2 #165

Feat/add generic velodyne decode fix/fix2 #165

ike-kazu commented Jun 19, 2024

ike-kazu commented Jun 19, 2024 •

edited

Loading

Feat/add generic velodyne decode fix/fix2 #165

Feat/add generic velodyne decode fix/fix2 #165

Conversation

ike-kazu commented Jun 19, 2024

PR Type

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

ike-kazu commented Jun 19, 2024 • edited Loading

ike-kazu commented Jun 19, 2024 •

edited

Loading