-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typos in the SetVelocityVehicle function #204
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thanks for the catch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 25.75% 0.00% -25.76%
==========================================
Files 99 86 -13
Lines 8757 7637 -1120
Branches 2173 895 -1278
==========================================
- Hits 2255 0 -2255
- Misses 6115 7637 +1522
+ Partials 387 0 -387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* chore: fix case style in common modules and their usages Signed-off-by: Max SCHMELLER <[email protected]> * chore(hesai): fix case style Signed-off-by: Max SCHMELLER <[email protected]> * chore(continental): fix case style Signed-off-by: Max SCHMELLER <[email protected]> * chore(robosense): fix case style Signed-off-by: Max SCHMELLER <[email protected]> * chore(velodyne): fix case style Signed-off-by: Max SCHMELLER <[email protected]> * chore: fix typos in the SetVelocity Vehicle function (#204) * docs: simplify installation instructions (#203) * docs: remove obsolete note about transport drivers Signed-off-by: Max SCHMELLER <[email protected]> * docs: remove recommendation to clone into `src` directory Signed-off-by: Max SCHMELLER <[email protected]> * chore: update link to about page Signed-off-by: Max SCHMELLER <[email protected]> * chore: add cmake ignore to meta package Signed-off-by: David Wong <[email protected]> --------- Signed-off-by: Max SCHMELLER <[email protected]> Signed-off-by: David Wong <[email protected]> Co-authored-by: David Wong <[email protected]> --------- Signed-off-by: Max SCHMELLER <[email protected]> Signed-off-by: David Wong <[email protected]> Co-authored-by: JonasKrug <[email protected]> Co-authored-by: David Wong <[email protected]>
PR Type
Description
It fixes the naming of an internal variable in the continental ars548 hardware interface code.
Review Procedure
Check that all occurrences of the misnamed variable were properly replaced.