Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai,velodyne): combine connection-related parameters into connection_mode #211

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

chore: fix typo in connection_mode schema

e29d0cd
Select commit
Loading
Failed to load commit list.
Open

chore(hesai,velodyne): combine connection-related parameters into connection_mode #211

chore: fix typo in connection_mode schema
e29d0cd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 25, 2024 in 0s

25.87% (-0.02%) compared to 214373a

View this Pull Request on Codecov

25.87% (-0.02%) compared to 214373a

Details

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 25.87%. Comparing base (214373a) to head (e29d0cd).

Files with missing lines Patch % Lines
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 14 Missing ⚠️
nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp 0.00% 7 Missing ⚠️
nebula_ros/src/velodyne/hw_interface_wrapper.cpp 0.00% 6 Missing ⚠️
...ula_common/include/nebula_common/nebula_common.hpp 0.00% 5 Missing ⚠️
nebula_ros/src/hesai/hw_interface_wrapper.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   25.88%   25.87%   -0.02%     
==========================================
  Files          99       99              
  Lines        9190     9195       +5     
  Branches     2211     2215       +4     
==========================================
  Hits         2379     2379              
- Misses       6426     6431       +5     
  Partials      385      385

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov