Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable all clang-tidy checks #229

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 18, 2024

PR Type

  • Improvement

Related Links

Description

Re-enable accidentally commented-out checks.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Nov 18, 2024
@mojomex mojomex merged commit 791fcc5 into main Nov 18, 2024
10 of 11 checks passed
@mojomex mojomex deleted the chore/re-enable-clang-tidy-checks branch November 18, 2024 06:35
@mojomex mojomex mentioned this pull request Nov 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant