Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hesai): set PTP lock offset on sensor configuration #239

Merged
merged 10 commits into from
Dec 3, 2024

docs(hesai): describe effects of `ptp_lock_threshold` parameter

a52297a
Select commit
Loading
Failed to load commit list.
Merged

fix(hesai): set PTP lock offset on sensor configuration #239

docs(hesai): describe effects of `ptp_lock_threshold` parameter
a52297a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 3, 2024 in 0s

26.07% (-0.05%) compared to 06be1f7

View this Pull Request on Codecov

26.07% (-0.05%) compared to 06be1f7

Details

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 26.07%. Comparing base (06be1f7) to head (a52297a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% 14 Missing ⚠️
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   26.11%   26.07%   -0.05%     
==========================================
  Files         101      101              
  Lines        9213     9232      +19     
  Branches     2212     2213       +1     
==========================================
+ Hits         2406     2407       +1     
- Misses       6418     6436      +18     
  Partials      389      389

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov