Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xt16): update default parameters and schema to comply with #239, #256 #259

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 4, 2025

PR Type

  • Bug Fix

Related Links

Description

Update parameter file and schema of XT16 to match the newest changes already merged for ther sensors.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Feb 4, 2025
@mojomex mojomex enabled auto-merge (squash) February 4, 2025 06:06
@mojomex mojomex disabled auto-merge February 4, 2025 06:06
@mojomex mojomex merged commit 48d9ab9 into main Feb 4, 2025
9 of 10 checks passed
@mojomex mojomex deleted the fix/xt16-param-update branch February 4, 2025 06:06
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (8edab25) to head (c079718).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8edab25) and HEAD (c079718). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8edab25) HEAD (c079718)
total 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #259       +/-   ##
==========================================
- Coverage   27.27%   0.00%   -27.28%     
==========================================
  Files         105      92       -13     
  Lines        9465    8109     -1356     
  Branches     2337     973     -1364     
==========================================
- Hits         2582       0     -2582     
- Misses       6435    8109     +1674     
+ Partials      448       0      -448     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant