fix(hesai_ros_wrapper): fix a bug where setting any parameter except return_mode during runtime fails

[mojomex]

PR Type

• Bug Fix

Related Links

• feat(hesai): implement mask-based pruning filter for Hesai #251 -- bug snuck in in this PR

Description

Forgot a ! when rearranging parameter parsing in on_parameter_change, causing the set_parameter service call to fail on every parameter except return_mode.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[knzo25]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.44%. Comparing base (c89e70c) to head (e61a0ee).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   30.23%   27.44%   -2.80%     
==========================================
  Files         112      112              
  Lines        9695     9486     -209     
  Branches     3653     2392    -1261     
==========================================
- Hits         2931     2603     -328     
- Misses       6224     6443     +219     
+ Partials      540      440     -100     

Flag	Coverage Δ
differential	27.44% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Common	18.37% <ø> (-31.87%)	⬇️
Hesai	29.69% <0.00%> (-0.72%)	⬇️
Velodyne	37.76% <ø> (+0.10%)	⬆️
Continental	28.06% <ø> (+0.07%)	⬆️
Robosense	0.00% <ø> (ø)