Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_msgs): add change topic relay control service #164

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Jan 19, 2025

Related Links

block-diagrams
autoware.universe PR

Description

This PR adds change topic relay control service to tier4_system_msgs directory.
It is called from redundancy_relay_manager to topic_relay_controller and represents whether to turn on or off the relaying topic. The topic_relay_controller is implemented with a design that does not rely on redundant configurations.

Remarks

Node Description

  • redundancy_relay_manager: placed on the Sub ECU side, it determines whether the Main ECU or the Sub ECU is currently in use, and when the Sub ECU is in use, it makes a service call to the relay_topic_controller and stops relaying the topic bridged from the Main ECU.
  • relay_topic_controller: remap the specified topic and republish it.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit 10a235a into tier4:tier4/universe Jan 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants