Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random fixes #4

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Random fixes #4

merged 1 commit into from
Jul 8, 2024

Conversation

JRI98
Copy link
Contributor

@JRI98 JRI98 commented Jul 4, 2024

No description provided.

@JRI98 JRI98 changed the title Fix docs links Random fixes Jul 4, 2024
emschwartz
emschwartz reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@emschwartz emschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links to the docs site should stay as is, but otherwise looks good. Thank you for spotting and fixing those issues!

exercises/005_create_transfer.sh Outdated Show resolved Hide resolved
@emschwartz emschwartz merged commit 4d6661f into tigerbeetle:main Jul 8, 2024
1 check failed
@JRI98 JRI98 deleted the fix_links branch July 8, 2024 17:41
@JRI98
Copy link
Contributor Author

JRI98 commented Jul 8, 2024 •
edited
Loading

Looks like patches no longer work https://github.com/tigerbeetle/tigerlings/actions/runs/9844327671/job/27177484070

@emschwartz
Copy link
Contributor

Ah right, didn't wait for the action to complete before merging. I'll fix that along with the issue you opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emschwartz emschwartz emschwartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JRI98 @emschwartz