Reorganize modules to match ghaf mainline stucture #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
buianhhuy96
commented
Apr 23, 2024
buianhhuy96
commented
- Move and rename some modules
buianhhuy96
force-pushed
the
reorganizing_fmo_services
branch
from
29fa5ec
to
744d0b6
Compare
buianhhuy96
force-pushed
the
reorganizing_fmo_services
branch
from
744d0b6
to
448ab16
Compare
jsvapiav
reviewed
May 10, 2024
flake.nix
Outdated
| (import ./installers/fmo-os-installer-public.nix) | ||
| ]; | ||
|
|
||
| #TODO Fix this |
There was a problem hiding this comment.
Ok. I should fix this, this comment belongs to ghaf mainline, I think they may run into some issue
There was a problem hiding this comment.
Than please give more meaningful comment here like and put down here that it belongs to ghaf mainline
There was a problem hiding this comment.
After checking it, I think we can delete it and update it when the mainline changes. It is just a syntax where they want to use import so nothing really affects us
| @@ -92,9 +93,10 @@ | |||
| microvm.qemu.bios.enable = false; | |||
| microvm.storeDiskType = "squashfs"; | |||
|
|
|||
| imports = (import "${ghafOS}/modules/module-list.nix") ++ (import ../../fmo-module-list.nix); | |||
| imports = (import "${ghafOS}/modules/module-list.nix"); | |||
There was a problem hiding this comment.
This works thanks to self.nixosModules.fmo-configs in line 44, which is define in the new fmo-module-list.nix
jsvapiav
reviewed
May 10, 2024
| # | ||
| # Allows us to structure the flake with the NixOS module system | ||
| flake-parts = { | ||
| url = "github:hercules-ci/flake-parts"; |
There was a problem hiding this comment.
This is to sync with ghaf mainline structure, where they modularize everything with self.nixosModules
- Move and rename some modules matching ghaf mainline structure - Create separate folder for hydrajobs - Modularize with flake-parts - Rewrite target config with flake-part modules Signed-off-by: Anh Huy Bui <[email protected]>
buianhhuy96
force-pushed
the
reorganizing_fmo_services
branch
from
448ab16
to
99f3a70
Compare
Signed-off-by: Ivan Kuznetsov <[email protected]>
Signed-off-by: Ivan Kuznetsov <[email protected]>
- Add host ipaddr and default route to configuration - Add updateHostConfig functionality Signed-off-by: Ivan Kuznetsov <[email protected]>
- Check if update docker-compose file exist - If so then backup original file - And update original docker-compose file with a new one Signed-off-by: Ivan Kuznetsov <[email protected]>
… from file - Use default CR URL if file does not exist - Use CR URL from file if it exists Signed-off-by: Ivan Kuznetsov <[email protected]>
- Update new installer version with docker url selection - Add installer configs for docker URLs Signed-off-by: Anh Huy Bui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.