Rebase ghaf release 2403 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
buianhhuy96
commented
May 8, 2024
buianhhuy96
commented
- Update flake.lock to ghaf 24.03
- Modify config-processor to use ghaf modules
- Rename microvm interface id from "vm-" to "tap-"
- Add skipped failed test for upstream package (python3/afdko)
- Remove local golang, go-app is now built with nixpkgs.buildGoModules
- Move and rename some modules matching ghaf mainline structure - Create separate folder for hydrajobs - Modularize with flake-parts - Rewrite target config with flake-part modules Signed-off-by: Anh Huy Bui <[email protected]>
- Update flake.lock to ghaf 24.03 - Modify config-processor to use ghaf modules - Rename microvm interface id from "vm-*" to "tap-*" - Add skipped failed test for upstream package (python3/afdko) - Remove local golang, go-app is now built with nixpkgs.buildGoModules Signed-off-by: Anh Huy Bui <[email protected]>
JoonasOnatsu
reviewed
May 8, 2024
| with lib; { | ||
| config.ghaf.graphics = mkIf cfg.enable { | ||
| weston.enable = lib.mkForce false; | ||
| sway.enable = true; |
There was a problem hiding this comment.
Should sway be force-enabled just in case?
There was a problem hiding this comment.
Well, sway is our own development, so it's only in our project, no need to override it with options (like ghaf mainline weston)
There was a problem hiding this comment.
maybe it is also good idea to move this choose to configuration files. But I think that it is no need to do that now.
- Move and rename some modules matching ghaf mainline structure - Create separate folder for hydrajobs - Modularize with flake-parts - Rewrite target config with flake-part modules Signed-off-by: Anh Huy Bui <[email protected]>
Signed-off-by: Ivan Kuznetsov <[email protected]>
Signed-off-by: Ivan Kuznetsov <[email protected]>
- Add host ipaddr and default route to configuration - Add updateHostConfig functionality Signed-off-by: Ivan Kuznetsov <[email protected]>
- Check if update docker-compose file exist - If so then backup original file - And update original docker-compose file with a new one Signed-off-by: Ivan Kuznetsov <[email protected]>
… from file - Use default CR URL if file does not exist - Use CR URL from file if it exists Signed-off-by: Ivan Kuznetsov <[email protected]>
- Update new installer version with docker url selection - Add installer configs for docker URLs Signed-off-by: Anh Huy Bui <[email protected]>
- Move and rename some modules matching ghaf mainline structure - Create separate folder for hydrajobs - Modularize with flake-parts - Rewrite target config with flake-part modules Signed-off-by: Anh Huy Bui <[email protected]>
- Update flake.lock to ghaf 24.03 - Modify config-processor to use ghaf modules - Rename microvm interface id from "vm-*" to "tap-*" - Add skipped failed test for upstream package (python3/afdko) - Remove local golang, go-app is now built with nixpkgs.buildGoModules Signed-off-by: Anh Huy Bui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.