FMO-36: Need the host default route to be added #46
Conversation
jsvapiav
commented
Jun 3, 2024
jsvapiav
commented
- Add host ipaddr and default route to configuration
- Add updateHostConfig functionality
Signed-off-by: Ivan Kuznetsov <[email protected]>
- Add host ipaddr and default route to configuration - Add updateHostConfig functionality Signed-off-by: Ivan Kuznetsov <[email protected]>
| @@ -76,6 +77,7 @@ let | |||
| ]; | |||
| } | |||
| ] | |||
| ++ updateHostConfig {inherit lib; inherit targetconf;} | |||
There was a problem hiding this comment.
I understand your idea. But in terms of syntax, is it config.systemd.network similar to above addSystemPackages (line 69). We can just directly write the config into this file, unless you want to keep it simple?
There was a problem hiding this comment.
Not sure, because it needs targetconf as parameter, which does not exist on translation stage above, and also for me this one looks better and cleaner. Probably at some point we need to move those functions down there also.
There was a problem hiding this comment.
Also all other functions probably need to be moved to separate files with proper names and definitions. But, it definitely something for future.
There was a problem hiding this comment.
Yeah, I think in the future we should organize the configs into separate files which then much easier to manage
