Add ability to delete all Linux Boot Manager entries #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariia Azbeleva <[email protected]>
Signed-off-by: Mariia Azbeleva <[email protected]>
Signed-off-by: Mariia Azbeleva <[email protected]>
Incoming ghaf PR#585 Change internal installation approach is going to change the installation method significantly. After the merge of PR#585 ghaf-installer will create always a new Linux Boot Manager entry to UEFI boot order list and thus set the machine to boot from nvme regardless if USB SSD is connected. Here introduced efiboot-mod test will automatically remove all Linux entries from the UEFI boot order list. Wiping nvme clear could do the same but it is not possible to automatically clear nvme if boot is locked to nvme. Also it is good to not let the UEFI boot order list be flooded endlessly with Linux Boot Manager entries. There is still a risk that the ghaf which the ghaf-installer has installed is broken and unbootable and new Linux Boot Manager entry is active. This would cause ci-test-automation not being able to boot automatically from nvme nor from USB SSD, and the system should be fixed manually (Linux Boot Manager removed). To avoid this happening plain ghaf image test should be ran first and only if the ghaf image is bootable then proceed to ghaf-installer tests. Signed-off-by: Samuli Leivo <[email protected]>
Signed-off-by: Samuli Leivo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#585 'Change internal installation approach' is going to change the installation method so that it does not anymore just flash the ghaf image on nvme but builds it with nixos-installer. After PR#585 is merged ghaf-installer will create always a new Linux Boot Manager entry to UEFI boot order list and thus set the machine to boot from nvme regardless if USB SSD is connected or not.
With the introduced efiboot-mod test all Linux Boot Manager entries can be automatically removed from the UEFI boot order list. Wiping nvme clear can force to boot from USB but it is not possible to clear nvme if machine is locked to boot from nvme. Also it is not good to let the UEFI boot order list be flooded endlessly with Linux Boot Manager entries.
There is still a risk that the ghaf which the ghaf-installer has installed is broken and unbootable and new Linux Boot Manager entry is active. This would cause ci-test-automation not being able to boot automatically from nvme nor from USB SSD. That situation would need to be fixed manually via booting to UEFI BIOS and deactivating Linux Boot Manager entries. To avoid this happening plain ghaf image test should be ran first and only if the ghaf image is bootable then proceed to ghaf-installer tests.
Running efiboot-mod test while there is no Linux Boot Manager entries present in UEFI Boot order list does no harm.
Requirement for this PR to work is that efibootmgr is added to ghaf. This was done in tiiuae/ghaf#605